fix: Proxy and client cert authentication #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjtang1985
requested changes
Mar 4, 2021
test-packages/integration-tests/test/auth-flows/auth-flow.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -29,10 +29,12 @@ export function getAgentConfig( | |||
| const agentType = destination.proxyConfiguration | |||
| ? AgentType.PROXY | |||
| : AgentType.DEFAULT; | |||
| // eslint-disable-next-line @typescript-eslint/no-shadow | |||
| const certificateOptions = getCertificateOption(destination); | |||
There was a problem hiding this comment.
I don't see shadow name. Could you please share a bit details?
There was a problem hiding this comment.
for me I got a lint error that the variable in the if block below is shadowed - I do not understand that either.
jjtang1985
approved these changes
Mar 5, 2021
|
For the failing unit test, if you need further review, just let me know. |
Co-authored-by: Junjie Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized while working on BAS that client certificate authentication is not working when also proxies are used.
I adjusted our code that the proxy settings are also passed to the http-agent. Unfortunately also the proxy agent itself does not forward the presented certificates to the target system. So they stay on the proxy and you get a 401.
I checked by locally adjusting the node modules that this PR TooTallNate/proxy-agents#111 fixes the issue, but the repo seems to be not very active. We can merge the code on our side but it will not work until we get an update on the node-https-proxy and this could take a while...