fix(visualize) Visualize smart click #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #186 and #189 - Audio recordings are now returned from the API in a consistent order (#189) - Tile navigation on `click` event changed to SVG `a` elements - better usability (acessibility, middle clicking, control clicking, right-clicking) - hover over to see link - pre computed links slightly faster - fixed a bug with tile generation behaviour (extra tiles are no longer generated) - tiles are also sorted when filtered (no z-indexing in svg, insertion order important) - also fixed bug where tiles would be prematurely cut from screen if the duration of the source audio was too short
|
This change also fixes a bug that prevented the listen page from loading audio if only the |
atruskie
added a commit
that referenced
this pull request
Mar 17, 2015
fix(visualize) Visualize smart click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(visualize) Navigating on tile click now works better
Fixes #185 and Fixes #189
clickevent changed to SVGaelements