Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visualization) Clicking/touching a tile can sometimes redirect to missing data #185

Closed
atruskie opened this issue Mar 9, 2015 · 5 comments · Fixed by #192
Closed

Comments

@atruskie
Copy link
Member

atruskie commented Mar 9, 2015

Currently, the click resolution in the visualization strip is 60px - the same size as the image tiles - which means a click essentially represents clicking somewhere in that 60mins.

Current behaviour is to index into start of hour long block.

This behaviour can lead to faulty redirects - particularly at edge cases like:

  • negatively indexing into an audio file
  • indexing past the end of an audio file

It leads users to pages with no audio and no error message - very bad.

Present suggested solution is to smartly index into where we know there is data and then rely on (a yet to be) enhanced navigation bar in listen interface for fine grained navigation.

This will be sufficient for most cases, however for cases where:

  • two sample-style recordings occur in the same hour long block
  • or where two larger recordings end and start respectively in the same block

which recording do we navigate to?

Suggested solution means that there would be essentially some files we could never navigate to. Opinions @jwim1, @cofiem ?

@atruskie atruskie added the bug label Mar 9, 2015
@cofiem
Copy link
Contributor

cofiem commented Mar 9, 2015

I think in here somewhere is the need to be able to go to the 'next' recording from the listen page. Exactly what 'next' means is not clear - perhaps prev and next in terms of audio recordings could be chronological order of recordings in the site (which would be transparent to the user - they wouldn't know it was a different recording)?

If prev and next was available over recordings, then it wouldn't matter about two or more recordings in an hour - pressing next would get there eventually.

@atruskie
Copy link
Member Author

atruskie commented Mar 9, 2015

yeah that's along what I was thinking - particularly the new enhanced nav bar on the listen page would show 24 hours around your current position, at the current site only... which allow a pundit to skip recordings

@cofiem
Copy link
Contributor

cofiem commented Mar 9, 2015

An enhanced fine-grained nav UI is definitely needed. i'm not sure what form this would take, but it could be as simple as pre-populated drop-downs or locking on to particular points in the dragable bar to aid in understanding the half minute segments available.

@atruskie
Copy link
Member Author

atruskie commented Mar 9, 2015

well i was thinking of simply reusing the distributionOverview - it is adequate and already made

It would also be an ideal place to try out the polynomial time scale idea

@cofiem
Copy link
Contributor

cofiem commented Mar 9, 2015

👍 to between 1 minute and 24 hours around current location at current site only.
reuse of distribution overview sounds like a great idea 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants