Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Set round end block to None on evaluation fail #426

Merged
merged 1 commit into from
Jan 16, 2025
Merged

🔧 Set round end block to None on evaluation fail #426

merged 1 commit into from
Jan 16, 2025
+1 −1

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 30, 2024 •
edited
Loading

Why?

  • All rounds that don't have an end depending on time, should have a None end. This includes FundingSuccessful, FundingFailed, all Settlement states, and all Migration states.

Testing?

  • No new tests needed since its something affecting the UI

@JuaniRios JuaniRios mentioned this pull request Oct 30, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios mentioned this pull request Oct 30, 2024
Merged
@JuaniRios JuaniRios requested review from Lederstrumpf, lrazovic and vstam1 and removed request for Lederstrumpf October 30, 2024 15:00
@JuaniRios JuaniRios marked this pull request as ready for review October 30, 2024 15:00
@JuaniRios JuaniRios changed the title Set round end block to None on evaluation fail 🔧 Set round end block to None on evaluation fail Oct 30, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 30, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (10/30/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios mentioned this pull request Oct 31, 2024
Merged
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 669b73b to 35b2861 Compare November 27, 2024 13:30
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 663d2eb to e970b74 Compare November 27, 2024 13:30
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 35b2861 to 43fa9e6 Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from e970b74 to 8684d26 Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 43fa9e6 to 946f64d Compare November 28, 2024 11:49
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 8684d26 to 1febc0a Compare November 28, 2024 11:49
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 946f64d to fe71617 Compare November 28, 2024 11:52
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 1febc0a to 926ce50 Compare November 28, 2024 11:53
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 06a8e9e to 57f33f9 Compare November 28, 2024 12:06
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 926ce50 to e894641 Compare November 28, 2024 12:06
This was referenced Nov 29, 2024
Merged
Merged
This was referenced Dec 9, 2024
Merged
Merged
@JuaniRios JuaniRios mentioned this pull request Dec 19, 2024
Merged
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 57f33f9 to 760014c Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from e894641 to b47e7f2 Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 760014c to 0921bdb Compare January 10, 2025 11:49
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from b47e7f2 to 615e0c8 Compare January 10, 2025 11:49
@lrazovic lrazovic force-pushed the 10-24-eth_compat._tests branch from 0921bdb to 44bb4a8 Compare January 15, 2025 13:00
@lrazovic lrazovic force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 615e0c8 to 0217600 Compare January 15, 2025 13:00
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 44bb4a8 to 0921bdb Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 0217600 to 615e0c8 Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 0921bdb to 0fd182d Compare January 16, 2025 09:46
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from 615e0c8 to f53d335 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 0fd182d to c1d16e0 Compare January 16, 2025 10:27
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from f53d335 to c44cce6 Compare January 16, 2025 10:27
@JuaniRios JuaniRios mentioned this pull request Jan 16, 2025
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025 •
edited
Loading

Merge activity

  • Jan 16, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:14 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 16, 7:15 AM EST: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 10-24-eth_compat._tests to graphite-base/426 January 16, 2025 12:10
@JuaniRios JuaniRios changed the base branch from graphite-base/426 to main January 16, 2025 12:12
@JuaniRios JuaniRios force-pushed the 10-30-set_round_end_block_to_none_on_evaluation_fail branch from c44cce6 to 0973ad0 Compare January 16, 2025 12:13
@JuaniRios JuaniRios merged commit fc3f6eb into main Jan 16, 2025
1 check passed
@JuaniRios JuaniRios deleted the 10-30-set_round_end_block_to_none_on_evaluation_fail branch January 16, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic