✅ ETH Compatibility Tests #425
Merged
+1,296
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
c3a0720 to
7961f2e
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
1cc1e7b to
1da3b0a
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
2 times, most recently
from
c819f56 to
1413c23
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
1da3b0a to
2fd7129
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
1413c23 to
d269daa
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
2fd7129 to
252f99a
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
d269daa to
88aabca
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
252f99a to
85c8505
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
88aabca to
f7cd35f
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
f7cd35f to
8a90f38
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
10 times, most recently
from
89e6c7e to
e552785
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
6e95419 to
098e693
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
946f64d to
fe71617
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
098e693 to
e12717a
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
06a8e9e to
57f33f9
Compare
This was referenced Nov 29, 2024
Merged
This was referenced Dec 9, 2024
Merged
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
e12717a to
d4e8393
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
57f33f9 to
760014c
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
d4e8393 to
70882fb
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
760014c to
0921bdb
Compare
lrazovic
approved these changes
Jan 14, 2025
lrazovic
force-pushed
the
10-24-eth_compat._tests
branch
from
0921bdb to
44bb4a8
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
44bb4a8 to
0921bdb
Compare
JuaniRios
force-pushed
the
10-14-ethereum_compatibility
branch
from
70882fb to
64849ec
Compare
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
2 times, most recently
from
0fd182d to
c1d16e0
Compare
JuaniRios
changed the base branch from
10-14-ethereum_compatibility
to
graphite-base/425
JuaniRios
added a commit
that referenced
this pull request
Jan 16, 2025
## What? - Add support for Ethereum based projects by letting users define the ethereum account that receives the tokens at the moment of participation. ## How? - Participation info structs now have a receiving_account field which is an XCM `Junction`. This has to be either `AccountKey20` or `AccountId32` - Issuers now define at project creation if they expect one or the other account `Junction`. - Existing participation extrinsics now call the inner participation functions with AccountId32 == caller - New participation extrinsics now accept a junction, and a signature. The signature will be checked against the account defined in the signature to prove ownership. ## Testing? In the next PR: #425 ## Anything Else? - For now we only support `sr25519` signatures for Polkadot/Substrate-based accounts, and `secp256k1` for Ethereum. - The Ethereum signatures need to follow the [`eth_signTypedData_v4`](https://docs.metamask.io/wallet/reference/json-rpc-methods/eth_signtypeddata_v4/) standard: https://eips.ethereum.org/EIPS/eip-712
JuaniRios
force-pushed
the
10-24-eth_compat._tests
branch
from
c1d16e0 to
2954cf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
How?