Next/20200606/v6 #5047
Merged
Next/20200606/v6 #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a '/' in the redis server string then we consider that the connection should be done other a unix socket.
In case of redis outage, the redis session was reset but the replies were still fetch even if there is none replies in the new session.
In sync mode, Suricata was waiting to have batch size alerts before logging them. This was introducing delay in some configuration with low traffic.
- Fix relative_offset keyword option to be relative in regards to the last content match - Change relative_offset to int32_t with bounds check to allow the full range of the packet buffer size (uint16_t) - Added checks for over/underflows - Changed the offset type to uint16_t because the offset is applied to the payload length, which is a uint16_t - Adjusted test cases to work relative to the content match - Added test case to verify bounds
This commit adds support for transform-specific options. During Setup, transforms have the signature string available for options detection. When a transform detects an option, it should convert the option into an internal format and supply a pointer to this format as the last argument to DetectSignatureAddTransform. Transforms that support options must provide a function in their Sigmatch table entry. When the transform is freed, a pointer to the internal format of the option is passed to this function.
This commit adds the definition of the new `pcrexform` transform.
This commit adds a new transform -- pcrexform -- that applies a regular expression to the transformation buffer. If an expression was captured, that is output to the transformation buffer. Otherwise, the transformation buffer is unchanged.
This commit registers the `pcrexform` transform.
This commit improves the description of the `tos` keyword by emphasizing that the value used should adhere to the guidelines in RFC2474. Instead of specifying the DSCP value directly, right shift the DSCP value and use that.
This was referenced Jun 9, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5046 without the widestring version lock as a fix was pushed upstream: VoidStarKat/widestring-rs#14