Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis update #4992

Closed
wants to merge 3 commits into from
Closed

Redis update #4992

wants to merge 3 commits into from

Conversation

regit
Copy link
Contributor

@regit regit commented May 29, 2020 •
edited
Loading

A small series of patches on redis support. The main one is the redis unix socket support that provide a slight boost in term of logging performance .

Link to redmine ticket:

Describe changes:

  • unix socket support for redis
  • fix reconnect in batch mode
  • ensure a dump per second

PRScript output (if applicable):

regit added 3 commits May 29, 2020 16:06
@regit
util-log-redis: add support for unix socket
e12437e 
If there is a '/' in the redis server string then we consider that
the connection should be done other a unix socket.
@regit
util-log-redis: fix reconnect in batch mode
21431f1 
In case of redis outage, the redis session was reset but the replies
were still fetch even if there is none replies in the new session.
@regit
util-log-redis: ensure a dump per second
3ae33bb 
In sync mode, Suricata was waiting to have batch size alerts before
logging them. This was introducing delay in some configuration with
low traffic.
@regit regit requested a review from a team as a code owner May 29, 2020 14:37
@victorjulien
Copy link
Member

I think we need tickets for each of the 3 commits here. Probably need backports for the fixes too, which starts with tickets.

@regit
Copy link
Contributor Author

regit commented Jun 5, 2020

@victorjulien issues created.

@victorjulien victorjulien mentioned this pull request Jun 9, 2020
Closed
@victorjulien
Copy link
Member

Merged in #5047, thanks Eric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regit @victorjulien