-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] Base modules #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [add] status message: javascript rendering * [imp] status message js: reuse existing qweb templates
1. load qweb template on demand 2. load qweb template only if not loaded yet 3. use promises for rendering We load qweb templates via JS. Prior to this change we got 1 request every time, on every page load, even if we were not using any status message feature. Now we load templates only when needed and we load it only if not loaded yet, lowering page load time a bit :) Plus, rendering now returns a promise object so you can chain calls and do things when rendering is really finished.
The example package was there only to show how a message would look like. But in real life you want always to verify how they look like with your theme styles applied. Now we have a new route `/cms/status-message/display-test` to check them. `cms_status_message_example` module has been removed.
cms_info is the base module, cms_delete_content must depend on it, not the other way around
Example module on how to use cms_delete_content to unify cms content deletion UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: