[12.0][MIG] Migrate cms_form modules #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [add] status message: javascript rendering * [imp] status message js: reuse existing qweb templates
1. load qweb template on demand 2. load qweb template only if not loaded yet 3. use promises for rendering We load qweb templates via JS. Prior to this change we got 1 request every time, on every page load, even if we were not using any status message feature. Now we load templates only when needed and we load it only if not loaded yet, lowering page load time a bit :) Plus, rendering now returns a promise object so you can chain calls and do things when rendering is really finished.
The example package was there only to show how a message would look like. But in real life you want always to verify how they look like with your theme styles applied. Now we have a new route `/cms/status-message/display-test` to check them. `cms_status_message_example` module has been removed.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Old approach for fake test models was giving bad behaviors even if the tests were not ran for this module. Now we init a real fake model only on test run.
Potentially you can apply form widgets to different type of fields. Easy case: apply a select to an integer field. In such case we should not rely on `selection` key to be there when extracting the value.
* use bootstrap-datetimepicker which will allow to reuse most of the same code for a datetime widget in the future. * default to current language date format * allow override of date format and placeholder via widget kwargs
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-cms-11.0/website-cms-11.0-cms_form Translate-URL: https://translation.odoo-community.org/projects/website-cms-11-0/website-cms-11-0-cms_form/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-cms-11.0/website-cms-11.0-cms_form Translate-URL: https://translation.odoo-community.org/projects/website-cms-11-0/website-cms-11-0-cms_form/
make cms_form installable, need more testing
12.0 cms_form migration
- Replace buggy bootstrap3 datepicker by Gijgo Datepicker https://github.com/atatanasov/gijgo
CO-3266 Miscellaneous improvements for project creation form
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the cms_form modules usable in v12.