Skip to content

Commit

Permalink
fix: new flakiness on queued in FF for unordered events (#30031)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

An unordered metric event makes the test fail, as we see the signature
one (performed after in 8081) instead of the tx one (performed first in
8080)

![Screenshot from 2025-01-31
17-28-34](https://github.com/user-attachments/assets/2e914122-b86a-409d-8f1a-0bf62fd7f148)

After looking at the logs, we can see how the 8081 event refers to the
signature event that happens after the transaction


![image](https://github.com/user-attachments/assets/b56e0e16-dfba-4987-a30e-92fe5e88f971)

Furthermore, the wait for chainID added here was pointing to the old
chainId, so now it's corrected and fixes remaining flakiness

- Firefox
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/121815/workflows/09665d6e-9173-434a-817f-f462ee489622/jobs/4508139
- Webapck
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/121815/workflows/09665d6e-9173-434a-817f-f462ee489622/jobs/4508106

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30031?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
seaona authored Jan 31, 2025
1 parent df3931e commit c75493d
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ describe('Queued Confirmations', function () {
// create deposit transaction in dapp 1
await createDepositTransaction(driver);

await driver.delay(2000);
await driver.delay(5000);

await switchToDAppTwoAndCreateSignTypedDataRequest(driver);

Expand Down Expand Up @@ -420,7 +420,7 @@ async function switchChainToDappOne(driver: Driver) {
// No dialog should appear as we already gave permissions to this network
await driver.waitForSelector({
css: '[id="chainId"]',
text: '0x539',
text: '0x3e8',
});
}

Expand Down

0 comments on commit c75493d

Please sign in to comment.