-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minor fixes to get working #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnadolny13
changed the title
fix: minor fixees to get working
fix: minor fixes to get working
Jun 1, 2023
Merged
Co-authored-by: Edgar R. M. <[email protected]>
edgarrmondragon
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeError: 'NoneType' object has no attribute 'storage'
onprefix = batch_config.storage.prefix or ""
#26Object '{schema_name}' already exists
during SnowflakeCREATE SCHEMA
#18ADD
,ALTER
, andRENAME
operations meltano/sdk#1114conform_record_data_types
requires a newlevel
kwarg and was failing because it was missing.column_exists
methods was being called a ton and was querying snowflake for all columns every time which was slow so I have it caching nowschema_exists
method failed for me becauseget_schema_names
returns all lower columns. It errored because it was trying to create a schema that already existed.create_sqlalchemy_engine
was effectively replaced withcreate_engine
lazy_chunked_generator
that was moved in SDKI'm able to test that this works with the sample tap-github data from the getting started guide.