Skip to content

Commit

Permalink
Move link check to release tests
Browse files Browse the repository at this point in the history
The link check often fails because of timeouts on the ensembl website,
so we only run the link check when we are releasing a new version.
  • Loading branch information
Redmar-van-den-Berg committed Feb 5, 2025
1 parent ce48223 commit adb95d2
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 10 deletions.
20 changes: 16 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,41 @@ on:
- 'v[0-9]+.[0-9]+.[0-9]+'

jobs:
check_version:
release_checks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: recursive

- name: Setup Miniforge
uses: conda-incubator/setup-miniconda@v3
with:
miniforge-version: latest
activate-environment: HAMLET
use-mamba: true

- name: Get shortened version of release tag
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV

- name: Check release version is set correctly in every file
run: python3 utilities/check-version.py ${{ env.RELEASE_VERSION }}

- name: Run release tests in conda environment
run: >-
pytest --keep-workflow-wd-on-fail
--tag release
run_tests:
uses: ./.github/workflows/ci.yml
needs:
- check_version
- release_checks

package:
name: Package source files
runs-on: ubuntu-latest
needs:
- check_version
- release_checks
- run_tests

steps:
Expand Down Expand Up @@ -60,7 +72,7 @@ jobs:
release:
name: Create release
needs:
- check_version
- release_checks
- run_tests
- package
runs-on: ubuntu-latest
Expand Down
6 changes: 0 additions & 6 deletions test/test_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,3 @@
- path: docs/build/html/genindex.html
contains:
- "expression"

- name: test-docs-links
tags:
- hamlet
- docs
command: make -C docs/ linkcheck
4 changes: 4 additions & 0 deletions test/test_release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- name: test-docs-links
tags:
- release
command: make -C docs/ linkcheck

0 comments on commit adb95d2

Please sign in to comment.