Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctor: check for beta XQuartz releases #459

Closed
wants to merge 1 commit into from
Closed

doctor: check for beta XQuartz releases #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Library/Homebrew/extend/os/mac/diagnostic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,18 @@ def check_for_latest_xquartz
https://xquartz.macosforge.org
EOS
end

def check_for_beta_xquartz
return unless MacOS::XQuartz.version.include? "beta"

<<-EOS.undent
The following beta release of XQuartz is installed: #{MacOS::XQuartz.version}

XQuartz beta releases include address sanitization, and do not work with
all software; notably, wine will not work with beta releases of XQuartz.
We recommend only installing stable releases of XQuartz.
EOS
end
end
end
end
5 changes: 5 additions & 0 deletions Library/Homebrew/test/test_diagnostic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,4 +226,9 @@ def test_check_for_external_cmd_name_conflict
end
end
end

def test_check_for_beta_xquartz
MacOS::XQuartz.stubs(:version).returns("2.7.10_beta2")
assert_match "The following beta release of XQuartz is installed: 2.7.10_beta2", @checks.check_for_beta_xquartz
end
end