doctor: check for beta XQuartz releases #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| XQuartz beta releases include address sanitization, and do not work with | ||
| all software; notably, wine will not work with beta releases of XQuartz. | ||
| We recommend only installing stable releases of XQuartz. | ||
| EOS |
There was a problem hiding this comment.
Would you mind indenting the contents between <<-EOS.undent and EOS by two spaces? That's the style we use in all other messages in this file.
|
This check is macOS-specific, thus it should most likely go into
This probably needs prefixing with |
mistydemeo
force-pushed
the
xquartz_beta_check
branch
from
03edc96 to
b891b6a
Compare
Beta versions of XQuartz have address sanitization enabled, which breaks some software at runtime, including wine. Closes Homebrew/homebrew-core#2481.
mistydemeo
force-pushed
the
xquartz_beta_check
branch
from
b891b6a to
ee7877d
Compare
souvik1997
pushed a commit
to souvik1997/brew
that referenced
this pull request
Jul 25, 2016
Beta versions of XQuartz have address sanitization enabled, which breaks some software at runtime, including wine. Closes Homebrew/homebrew-core#2481. Closes Homebrew#459. Signed-off-by: Misty De Meo <[email protected]>
iMichka
pushed a commit
to iMichka/brew
that referenced
this pull request
Sep 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Beta versions of XQuartz have address sanitization enabled, which breaks some software at runtime, including wine. This is likely to result in more confusing error reports if we don't add a warning about it.
Closes #2481.