Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http_check.validate_ssl monitoring-api #2441

Conversation

dustinblackman
Copy link
Contributor

@dustinblackman dustinblackman commented Oct 8, 2019

Overview

Adds validateSsl to monitoring API's httpCheck.

Docs: https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.uptimeCheckConfigs#httpcheck

Looks towards fixing hashicorp/terraform-provider-google#4631

Release Note Template for Downstream PRs (will be copied)

`monitoring`: Added `validate_ssl` to `google_monitoring_uptime_check_config`

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@dustinblackman
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ef274f1.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1243
depends: GoogleCloudPlatform/terraform-google-conversion#224
depends: hashicorp/terraform-provider-google#4637

@dustinblackman
Copy link
Contributor Author

@emilymye Is there anything that I may be missing here? More than happy to do updates if there are any.

@emilymye
Copy link
Contributor

@dustinblackman sorry for the very long delay! I actually was on leave for a bit and we missed re-assigning this. I'll go ahead and review this now.

@emilymye
Copy link
Contributor

emilymye commented Nov 11, 2019

Works for me! Do you mind adding a test for this? It'd involve adding a example file like templates/terraform/examples/uptime_check_config_http.tf.erb and adding it under UptimeCheckConfig.examples in the terraform.yaml like this:

examples:
- !ruby/object:Provider::Terraform::Examples
name: "uptime_check_config_http"
primary_resource_id: "http"
vars:
display_name: "http-uptime-check"
test_env_vars:
project_id: :PROJECT_NAME

@dustinblackman
Copy link
Contributor Author

@emilymye Whoops, I missed that there were tests in the repo. Sorry about that! Added them. :)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, ce0b92b.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@emilymye emilymye self-requested a review November 12, 2019 00:40
Dustin Blackman and others added 3 commits November 12, 2019 00:45
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 9f0ff22 into GoogleCloudPlatform:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants