-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add http_check.validate_ssl monitoring-api #2441
add http_check.validate_ssl monitoring-api #2441
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs. Thanks for your contribution! A human will be with you soon. @emilymye, please review this PR or find an appropriate assignee. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in Ansible. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
@emilymye Is there anything that I may be missing here? More than happy to do updates if there are any. |
@dustinblackman sorry for the very long delay! I actually was on leave for a bit and we missed re-assigning this. I'll go ahead and review this now. |
Works for me! Do you mind adding a test for this? It'd involve adding a example file like templates/terraform/examples/uptime_check_config_http.tf.erb and adding it under magic-modules/products/monitoring/terraform.yaml Lines 88 to 95 in 3dcdd29
|
@emilymye Whoops, I missed that there were tests in the repo. Sorry about that! Added them. :) |
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesterraform-provider-google-beta already has an open PR. New Pull RequestsI didn't open any new pull requests because of this PR. |
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
ce0b92b
to
d549e22
Compare
Overview
Adds
validateSsl
to monitoring API'shttpCheck
.Docs: https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.uptimeCheckConfigs#httpcheck
Looks towards fixing hashicorp/terraform-provider-google#4631
Release Note Template for Downstream PRs (will be copied)