Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring_uptime_check_config: Add validate_ssl to http_check #4631

Closed
dustinblackman opened this issue Oct 8, 2019 · 5 comments
Closed
Labels

Comments

@dustinblackman
Copy link

dustinblackman commented Oct 8, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently Stackdriver's uptime check configs don't enable validating SSL certificates by default. The parameter is available as validateSsl within httpCheck.

https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.uptimeCheckConfigs#httpcheck

Screen Shot 2019-10-08 at 11 21 18 AM

New or Affected Resource(s)

  • google_monitoring_uptime_check_config

Potential Terraform Configuration

resource "google_monitoring_uptime_check_config" "default" {
  display_name = "my-name"
  project      = "my-project"
  timeout      = "30s"
  period       = "60s"

  http_check {
    path    = "/"
    port    = "443"
    use_ssl = true
    validate_ssl = true
  }

  monitored_resource {
    type = "uptime_url"

    labels = {
      project_id = "project-id"
      host       = "google.com"
    }
  }
}

References

GoogleCloudPlatform/magic-modules#2441

@ghost ghost added the enhancement label Oct 8, 2019
@dustinblackman
Copy link
Author

I'd be happy to work on this in hopes to get it in the next release.

@stepanstipl
Copy link

There is also already an auto-generated PR opened against this provider - #4637 (and beta - hashicorp/terraform-provider-google-beta#1243)

@dustinblackman
Copy link
Author

@stepanstipl Yep, from the PR made on magic modules. GoogleCloudPlatform/magic-modules#2441

@megan07
Copy link
Contributor

megan07 commented Nov 20, 2019

Thanks @dustinblackman for opening this issue! It's been closed with GoogleCloudPlatform/magic-modules#2441 and was released in version 2.20.0.

@megan07 megan07 closed this as completed Nov 20, 2019
@ghost
Copy link

ghost commented Dec 21, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 21, 2019
@github-actions github-actions bot added forward/review In review; remove label to forward service/monitoring-uptime labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants