add examples for different resolveMode options. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR contains another commit since I am working against the master branch as noted in CONTRIBUTING and making the PR against the develop branch as noted in the PULL_REQUEST_TEMPLATE |
brettstack
approved these changes
Feb 24, 2019
|
Sorry, that contributing guide is incorrect (default/standard from AWS). I'll change it to request changes are made based on develop branch. |
Craigfis
reviewed
Jul 27, 2020
| // i.e. errors still lead to a resolved promise | ||
| // The resolved promise has a a statusCode property that can be checked for error codes | ||
|
|
||
| exports.handler = async (event, context) => { return awsServerlessExpress.proxy(server, event, context, 'PROMISE') } |
There was a problem hiding this comment.
the .proxy call should be suffixed with .promise I believe.
There was a problem hiding this comment.
If your handler is't doing any more async work why would someone use this feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #173 (#134)
Description of changes:
Add documentation for reolveMode options
PROMISEandCALLBACKBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.