Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #179

Merged
merged 5 commits into from
Oct 14, 2018
Merged

Develop #179

merged 5 commits into from
Oct 14, 2018

Conversation

brettstack
Copy link
Collaborator

Please ensure all pull requests are made against the develop branch.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the ^ symbols from the package-lock.json file. Was this intentional?

Edit: it looks like this change was made in #177 on develop.

@brettstack
Copy link
Collaborator Author

They shouldn't be there. They were added in this 2de9bba#diff-32607347f8126e6534ebc7ebaec4853d though I'm not sure why.

@keetonian
Copy link

Ok. It looks like the correct dependencies are still in place and the ones you updated are still updated. ^ is shorthand to use the latest minor version; I think this should still be fine and won't break anything.

@brettstack brettstack merged commit cb3b17d into master Oct 14, 2018
brettstack added a commit that referenced this pull request Mar 26, 2019
chore: merge pull request #179 from awslabs/develop
@brettstack
Copy link
Collaborator Author

🎉 This PR is included in version 3.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants