fix(ci): Wait for infra deployment before deploying apps in prod pipeline

[oskogstad]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the CI/CD production workflow by modifying the dependency chain of the deploy-apps job. The job’s needs attribute is updated to require both the check-for-changes and deploy-infra jobs before executing. The existing conditional logic checking for backend changes remains unchanged.

Changes

File Path	Change Summary
.github/workflows/ci-cd-prod.yml	Updated the deploy-apps job dependency from [check-for-changes] to [check-for-changes, deploy-infra].

Possibly related PRs

• ci: ensure we deploy infra and apps only when necessary #1980: Involves adjustments to job dependencies in the deployment workflow.
• chore(ci): Releasing NuGet depends on app-deploy #1920: Updates dependency relationships between jobs, particularly linking deploy-apps with other jobs.

Suggested reviewers

• arealmaas
• MagnusSandgren

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.github/workflows/ci-cd-prod.yml (1)

80-82: Dependency Chain Update: Ensure deploy-apps Waits for Infra Deployment

The needs attribute for the deploy-apps job has been updated to include both check-for-changes and deploy-infra, which aligns with the PR objective to wait for infra deployment before deploying apps. However, please verify that if the deploy-infra job is skipped (due to no infra changes), this dependency does not unintentionally block the deploy-apps job. It might be helpful to add a comment or extra condition if special handling for a skipped state of deploy-infra is needed.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2170a3d and 05009c3.

📒 Files selected for processing (1)

• .github/workflows/ci-cd-prod.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Dry run deploy infrastructure / Deploy to test
• GitHub Check: build / build-and-test

[arealmaas]

Oi, nice catch!