chore(ci): Releasing NuGet depends on app-deploy #1920

oskogstad · 2025-02-20T10:13:17Z

No description provided.

coderabbitai · 2025-02-20T10:13:25Z

📝 Walkthrough

Walkthrough

This pull request updates the CI/CD workflow configurations across main, production, and staging environments. It modifies the dependencies and conditional checks for the publish-sdk-to-nuget job by adding deploy-apps as a prerequisite and enhancing its if-condition to include status checks. Additional changes update the conditional execution of the store-apps-version job in production and staging, and modify the dependencies of the run-e2e-tests job in staging.

Changes

File(s)	Change Summary
`…/ci-cd-main.yml`, `…/ci-cd-prod.yml`, `…/ci-cd-staging.yml`	Updated `publish-sdk-to-nuget` job: added `deploy-apps` to the `needs` list and enhanced the `if` condition to include `always()`, `!failure()`, and `!cancelled()` along with the pre-existing Swagger schema check.
`…/ci-cd-prod.yml`, `…/ci-cd-staging.yml`	Updated `store-apps-version` job: modified the `if` condition to use `always() && !failure()` and ensure execution only when the `deploy-apps` job indicates a successful deployment (with an extra dispatch event check in prod).
`…/ci-cd-staging.yml`	Updated `run-e2e-tests` job: added `deploy-apps` to the dependency list to ensure it runs after both `deploy-apps` and `check-for-changes` complete.

Possibly related PRs

ci: ensure version is stored on app deploy #1762: Addresses similar dependency and conditional logic updates in the CI/CD workflows, particularly involving the publish-sdk-to-nuget and store-apps-version jobs.
ci: separate between dry-run and real production deploy #1759: Involves modifications to the publish-sdk-to-nuget job by adding deploy-apps to its dependencies, aligning closely with the changes in this PR.

Suggested reviewers

knuhau
arealmaas

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5adda59 and c5a9380.

📒 Files selected for processing (3)

.github/workflows/ci-cd-main.yml (1 hunks)
.github/workflows/ci-cd-prod.yml (1 hunks)
.github/workflows/ci-cd-staging.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Dry run deploy infrastructure / Deploy to test

🔇 Additional comments (6)

.github/workflows/ci-cd-prod.yml (2)

103-104: Update publish-sdk-to-nuget job dependencies and condition
The job now requires both deploy-apps and check-for-changes to complete, and the expanded condition (always() && !failure() && !cancelled() && needs.check-for-changes.outputs.hasSwaggerSchemaChanges == 'true') provides additional safeguards before publishing to NuGet. This change aligns with the goal of ensuring deployment robustness.

112-119: Enhance store-apps-version job condition for production
The updated if clause—checking for either a manual trigger via workflow_dispatch or that deploy-apps successfully executed—ensures that the version storing step runs only when appropriate. This reinforces consistency in the CI/CD flow.

.github/workflows/ci-cd-staging.yml (3)

82-85: Update publish-sdk-to-nuget job in staging
The staging workflow now mirrors production by including deploy-apps in the needs array and adding the enhanced conditional check. This adjustment helps ensure that the NuGet publishing step correctly reflects deployment prerequisites in staging.

93-96: Review store-apps-version job condition in staging
The condition now verifies that deploy-apps has executed successfully before proceeding. Notably, it does not include a workflow_dispatch clause as in production. Please confirm that this difference is intentional and appropriate for the staging environment.

119-121: Refine run-e2e-tests job dependency
By adding deploy-apps to the dependencies, the end-to-end tests are now ensured to run only after the apps are deployed. This dependency update is a solid enhancement to the workflow sequencing.

.github/workflows/ci-cd-main.yml (1)

103-104: Refine publish-sdk-to-nuget job in main workflow
The update adds deploy-apps to the list of prerequisite jobs and expands the conditional execution using always() && !failure() && !cancelled(). This change ensures that the NuGet publication only proceeds when all critical steps (including app deployment) succeed. The consistency with production and staging workflows is a positive improvement.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

🤖 I have created a release *beep* *boop* --- ## [1.55.0](v1.54.0...v1.55.0) (2025-02-20) ### Features * **webapi:** Add flag for disabling SystemLabel reset ([#1921](#1921)) ([a5689f2](a5689f2)) ### Bug Fixes * **webapi:** Add missing 404 status code in activity list swagger schema ([#1924](#1924)) ([8f382cd](8f382cd)) * **webapi:** Add missing status codes in swagger docs for transmissions endpoints ([#1926](#1926)) ([2458d6a](2458d6a)) ### Miscellaneous Chores * **ci:** Releasing NuGet depends on app-deploy ([#1920](#1920)) ([37f9990](37f9990)) * **ci:** Use correct project path for NuGet publishing ([#1925](#1925)) ([7507187](7507187)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

fix

c5a9380

oskogstad requested review from a team as code owners February 20, 2025 10:13

oskogstad temporarily deployed to test February 20, 2025 10:13 — with GitHub Actions Inactive

oskogstad had a problem deploying to test February 20, 2025 10:14 — with GitHub Actions Failure

arealmaas approved these changes Feb 20, 2025

View reviewed changes

MagnusSandgren approved these changes Feb 20, 2025

View reviewed changes

oskogstad merged commit 37f9990 into main Feb 20, 2025
16 of 17 checks passed

oskogstad deleted the chore/releasing-nuget-should-depend-on-app-deploy branch February 20, 2025 12:34

dialogporten-bot mentioned this pull request Feb 20, 2025

chore(main): release 1.55.0 #1922

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): Releasing NuGet depends on app-deploy #1920

chore(ci): Releasing NuGet depends on app-deploy #1920

oskogstad commented Feb 20, 2025

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

chore(ci): Releasing NuGet depends on app-deploy #1920

chore(ci): Releasing NuGet depends on app-deploy #1920

Conversation

oskogstad commented Feb 20, 2025

coderabbitai bot commented Feb 20, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot commented Feb 20, 2025 •

edited

Loading