Save precise start times per TP #2408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time is saved as global string as ISO8601 timestamp. The specialized HW_XX_StartAcq have been made static and the calling locations adapted to use the public HW_StartAcq function.
No functional changes
In our TP data we used until now only simply DateTime of the moment the data was sent into analysis for the timestamp. This resulted in multiple TPs (all from the same new FIFO data) having nearly the same timestamp. Now the timestamp of each TP based on the acquisition start and TP position in the acquisition is determined. Note regarding the calculation: (tpCounter + i) * tpInput.samplingIntervalDAC * tpInput.tpLengthPointsDAC * MILLI_TO_ONE tpCounter originates from NI devices in TP acquisition mode. There the acquisition with a single TP repeats itself in hardware. The TPs are counted based on the FIFO data and each TP is sent to SCOPE_UpdateOscilloscopeData separately. Thus, i is always zero and tpCounter the number of the TP since acquisition start. For all other hardware devices and acquisition modes tpCounter is zero and i counts the absolute TP number based on the position of the data in the FIFO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #336