AB: Add column in experiment information list box for sweep time #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n part For later use in the AB a non-asserting function is required. No functional changes.
A column was added at the right side of the listbox with the experiment information that shows the session start time of the experiment file. All NWB versions support this field. For PXPs the time of the first sweep acquisition from the LBN is shown. For old PXPs where this LBN entry does not exist the listbox cell is left empty. Another small empty column was added on the right to reserve space where the vertical scrollbar appears. Otherwise the scrollbar covers information. The column widths were adjusted such that the horizontal size increase of the AB is minimal. The version of the AB and listbox wave was increased.
MichaelHuth
force-pushed
the
feature/2407-add_ab_col_time
branch
from
64b1ae3 to
fb09f30
Compare
|
Review: Makes sense. fb09f30 (AB: Add column in experiment information list box for session start time, 2025-04-24)
strswitch(fileType)
case ANALYSISBROWSER_FILE_TYPE_IGOR:
...
break
case ANALYSISBROWSER_FILE_TYPE_NWBv1:
case ANALYSISBROWSER_FILE_TYPE_NWBv2: // intended fallthrough
...
break
default:
ASSERT(0, "invalid file type")
endswitchso that we catch missing spots when we ever introduce a third data source.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A column was added at the right side of the listbox with the experiment information that shows the time when the sweep was acquired.
Another small empty column was added on the right to reserve space where the vertical scrollbar appears. Otherwise the scrollbar covers information.
The column widths were adjusted such that the horizontal size increase of the AB is minimal.
The version of the AB and listbox wave was increased.
close #2251