-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Adds support for decimal qualifiers. Resolves #91 #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=========================================
+ Coverage 84.31% 84.4% +0.09%
=========================================
Files 26 26
Lines 3150 3162 +12
Branches 469 473 +4
=========================================
+ Hits 2656 2669 +13
Misses 362 362
+ Partials 132 131 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code looks good.
- Please order the test alphabetically in the file.
@@ -193,6 +193,23 @@ public void ParseLambda_ParameterName_Null() | |||
} | |||
|
|||
[Fact] | |||
public void ParseLambda_RealNumbers() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the test alphabetically in the file.
@@ -657,6 +657,38 @@ public void ExpressionTests_FloatQualifiers_Negative() | |||
} | |||
|
|||
[Fact] | |||
public void ExpressionTests_DecimalQualifiers() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the test alphabetically in the file.
} | ||
|
||
[Fact] | ||
public void ExpressionTests_DecimalQualifiers_Negative() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the test alphabetically in the file.
@@ -132,6 +132,30 @@ public void TextParser_Parse_RealLiteralPlus() | |||
} | |||
|
|||
[Fact] | |||
public void TextParser_Parse_RealLiteralFloatQualifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the test alphabetically in the file.
} | ||
|
||
[Fact] | ||
public void TextParser_Parse_RealLiteralDecimalQualifier() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order the test alphabetically in the file.
Thanks. Can you take a look at the review? |
It's done! I already ordered the tests, except for ParseLambda_IllegalMethodCall_ThrowsException which is below all the others. |
I also added a test for real numbers and checked that all tests pass successfully.