bind expressions to correct constructor parameter

[jonasdaniels]

class test {
  int a;
  int b;
  int c; 
}

if ConstructorInfo ci.GetParameters() returns ParameterInfo[] {int a, int b, int c }

Picking them up by index works in most cases.
ex.
new(1 as a, 2 as b, 3 as c ) => {a = 1, b = 2, c = 3 }
but not if the identifiers are moved around(for example using the same type again)
new(1 as b, 2 as a, 3 as c ) => { a =1, b = 2, c = 3 }

Proposed solution.
Make sure to map the correct expression based the identifier to the same(based on type and name) constructor parameter

[StefH]

@jonasdaniels

Can you maybe add a unit test to:
https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/93d93d7b807d9881217a2841c3025ec4dc4aba69/test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionParserTests.TypeAccess.cs ?

[StefH]

please take a look at my comments

[StefH]

@jonasdaniels

Can you double check if all tests run fine?

At my system, I get this test error:

 System.Linq.Dynamic.Core.Tests.QueryableTests.Select_Dynamic_IntoTypeWithNullableProperties2
   Source: QueryableTests.Select.cs line 253
   Duration: 26 ms

  Message: 
System.InvalidOperationException : Sequence contains no matching element

  Stack Trace: 
ThrowHelper.ThrowNoMatchException()
Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
ExpressionParser.CreateNewExpression(List`1 properties, List`1 expressions, Type newType) line 1480
ExpressionParser.ParseNew() line 1408
ExpressionParser.ParseIdentifier() line 991
ExpressionParser.ParsePrimaryStart() line 772
ExpressionParser.ParsePrimary() line 741
ExpressionParser.ParseUnary() line 736
ExpressionParser.ParseMultiplicative() line 682
ExpressionParser.ParseAdditive() line 651
<5 more frames...>
ExpressionParser.ParseOrOperator() line 265
ExpressionParser.ParseLambdaOperator() line 245
ExpressionParser.ParseNullCoalescingOperator() line 232
ExpressionParser.ParseConditionalOperator() line 216
ExpressionParser.Parse(Type resultType, Boolean createParameterCtor) line 154
DynamicExpressionParser.ParseLambda(Type delegateType, ParsingConfig parsingConfig, Boolean createParameterCtor, ParameterExpression[] parameters, Type resultType, String expression, Object[] values) line 122
DynamicExpressionParser.ParseLambda(ParsingConfig parsingConfig, Boolean createParameterCtor, ParameterExpression[] parameters, Type resultType, String expression, Object[] values) line 97
DynamicExpressionParser.ParseLambda(ParsingConfig parsingConfig, Boolean createParameterCtor, Type itType, Type resultType, String expression, Object[] values) line 355
DynamicQueryableExtensions.Select[TResult](IQueryable source, ParsingConfig config, String selector, Object[] args) line 1803
QueryableTests.Select_Dynamic_IntoTypeWithNullableProperties2() line 264

[StefH]

I see that you have updated the unit-tests, but actually I was expecting that you would fix the code, because the unit-test did work before, and ideally the unit-test should continue working, also with your new code.

Sop can you please take a look at the code and see if you can fix the code so that the unit-test can stay the same?

[jonasdaniels]

@StefH
Reverted the test changes and added code to sequentially bind parameters.

However it feels unintuitiv to bind to the field names instead of the parameters names.

In the case:
QueryableTests.Select.cs line 265: "new (it as Time, DayOfWeek as DOWNull, DayOfWeek as DOW, Second as Sec, int?(Second) as SecNull)");"
it might make more sence to bind towards the fields since we dont have contructor with these names?