Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MethodCallExpression when using NullPropagating (np) #443

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Fix MethodCallExpression when using NullPropagating (np) #443

merged 4 commits into from
Oct 30, 2020

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Oct 29, 2020

@StefH StefH requested a review from JonathanMagnan October 29, 2020 06:02
@StefH
Copy link
Collaborator Author

StefH commented Oct 29, 2020

@JonathanMagnan Some other unit tests fail, so do not merge this PR yet.

@zspitz zspitz mentioned this pull request Oct 29, 2020
Closed
@StefH
Copy link
Collaborator Author

StefH commented Oct 29, 2020

Hello @JonathanMagnan, I did fix the code + unit tests. If you agree, I can merge this to master.

When that's doneI will start looking at #444.

@JonathanMagnan
Copy link
Member

Hello @StefH ,

I should be able to look at it tomorrow.

@JonathanMagnan
Copy link
Member

Look good ;)

Let me know if you wish I release during the weekend or wait for the #444 fix

@JonathanMagnan JonathanMagnan merged commit f523d2b into master Oct 30, 2020
@StefH StefH deleted the stef_np_432 branch November 14, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanMagnan JonathanMagnan Awaiting requested review from JonathanMagnan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefH @JonathanMagnan