Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ef core 3x support #402

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Ef core 3x support #402

merged 2 commits into from
Jul 27, 2020

Conversation

JonathanMagnan
Copy link
Member

No description provided.

Remove support to EF Core 1.1
Add EF Core 2.0.1 support
Add EF Core 3.1 support
remove unused project
@JonathanMagnan JonathanMagnan merged commit 1bb138a into master Jul 27, 2020
@StefH
Copy link
Collaborator

StefH commented Jul 27, 2020

@JonathanMagnan

I would not expect these duplicate files in the EF3 folder:
image

Was it not possible to use file links?

@JonathanMagnan
Copy link
Member Author

They are here only once in the EF Core 3 project: https://github.com/zzzprojects/System.Linq.Dynamic.Core/tree/master/src/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore3

Other files were removed

@StefH
Copy link
Collaborator

StefH commented Jul 27, 2020

Perfect ! I did not expect these here.

I'm used to build it the other way : keep the files in the old and make links in the new.

But your solution also works perfectly !

@JonathanMagnan
Copy link
Member Author

Would have probably done it as well the way you initially did but it was too late so I choose to keep it like it ;)

@StefH StefH deleted the EFCore_3x_Support branch June 26, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants