-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested Cosmos Db compatibility #352
Nested Cosmos Db compatibility #352
Conversation
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
+ Coverage 88.13% 88.46% +0.33%
==========================================
Files 46 46
Lines 4500 4509 +9
==========================================
+ Hits 3966 3989 +23
+ Misses 534 520 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, I never thought this library could be used for CosmosDB.
I'm reviewing the code, some comments are added, probably need some more time to check other items.
src-console/ConsoleApp_netcore2.1_CosmosDb/ConsoleApp_netcore2.1_CosmosDb.csproj
Outdated
Show resolved
Hide resolved
My pleasure - such a great library, I only hope my contribution is up to standard. It's been phenomenally useful for our project with Cosmos Db (we use it in conjunction with the Cosmonaut library). This issue with the nested queries was the final hurdle for us to allow for more complicated queries. |
… string.IsNullOrWhiteSpace.
@StefH Any further changes required? |
@countincognito Thanks for this PR and your reworked code. I'm doubting if I should just add this to the next version 1.0.21 / 1.0.22 or that I should use a higher version like 1.1.0 |
Thanks for approving it. Glad the changes will be of use. |
There seems to be an issue when using nested queries (i.e. >1 level deep), such as Sum() and Any(), which causes the query provider in the Azure Cosmos SDK to generate invalid SQL. I was able to fix it by overriding empty parameter expression names. Apologies if I have missed anything.