Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix New() support for Type + Fix GroupJoin() not working when using Linq-To-Entities (2) #208

Merged
merged 12 commits into from
Oct 19, 2018

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Oct 18, 2018

based on #207

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #208 into master will decrease coverage by 0.1%.
The diff coverage is 64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage    82.6%   82.49%   -0.11%     
==========================================
  Files          37       37              
  Lines        3685     3702      +17     
  Branches      507      508       +1     
==========================================
+ Hits         3044     3054      +10     
- Misses        499      501       +2     
- Partials      142      147       +5
Impacted Files Coverage Δ
...eProviders/DefaultDynamicLinqCustomTypeProvider.cs 0% <0%> (ø) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 78.42% <100%> (-0.12%) ⬇️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 94.44% <100%> (+0.32%) ⬆️
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 95.86% <100%> (+0.13%) ⬆️
...Providers/AbstractDynamicLinqCustomTypeProvider.cs 89.18% <78.57%> (+1.18%) ⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 97.05% <0%> (-0.99%) ⬇️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 86.79% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0967e9a...fa913f0. Read the comment docs.

@StefH
Copy link
Collaborator Author

StefH commented Oct 18, 2018

@david-garcia-garcia ; can you take a look at my changes in this PR?

@david-garcia-garcia
Copy link
Contributor

I made a small comment. Overall looks good, an a much better approach to controlling the type resolvers.

Just a couple of comments related to this PR:

  • This will be a breaking change, as IDynamicLinkCustomTypeProvider has grown. It is very very easy to fix, and probably IDynamicLinkCustomTypeProvider is not used by most implementation of this library.
  • An indirect consequence of the new capabalities of the library is that the PromoteExpression method in Expression parser needs some extra love because when destination DTO is strongly typed then type matching is way more strict and this method needs to be more powerful to deal with int32-int64, Guid's and the like, I already have some changes in that respect, but it's better for a follow-up

@StefH
Copy link
Collaborator Author

StefH commented Oct 19, 2018

  1. I will update version to the next one. So 1.0.9.0

  2. Ok lets first complete this PR and make sure it works perfect.

Thanks for your help.

@StefH StefH merged commit b85093e into master Oct 19, 2018
@StefH StefH deleted the stef_assembly_get_type branch October 19, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants