support group by with 2 parameters, add tolist #103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
+ Coverage 84.24% 84.3% +0.05%
=========================================
Files 26 26
Lines 3243 3255 +12
Branches 481 483 +2
=========================================
+ Hits 2732 2744 +12
Misses 379 379
Partials 132 132
Continue to review full report at Codecov.
|
|
and what about this? |
| @@ -181,6 +182,7 @@ interface IEnumerableSignatures | |||
| void LastOrDefault(); | |||
| void Single(); | |||
| void SingleOrDefault(); | |||
| void ToList(); | |||
There was a problem hiding this comment.
Is there a test to cover this method?
There was a problem hiding this comment.
Yes in ParseLambdaComplex_2
| @@ -181,6 +182,7 @@ interface IEnumerableSignatures | |||
| void LastOrDefault(); | |||
| void Single(); | |||
| void SingleOrDefault(); | |||
| void ToList(); | |||
There was a problem hiding this comment.
And a function like ToArray, can that also be defined?
There was a problem hiding this comment.
Think so, but I've not tested/used
| @@ -54,6 +54,48 @@ public void ParseLambda_EmptyParameterList() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ParseLambdaComplex_1() | |||
There was a problem hiding this comment.
Is it possible to move this test to the file QueryableTests.GroupBy.cs or does that not fit?
There was a problem hiding this comment.
The other tests in this class (for example ParseLambda_1) also test Lambda with GroupBy
|
I did add some question to this code-review. |
| } | ||
|
|
||
| [Fact] | ||
| public void ParseLambdaComplex_2() |
There was a problem hiding this comment.
This tests ToList()
No description provided.