Optimizations and Upgrades #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- speeds up about 1-2s
- overall it's about the same speed (likely disk stat itself is the bottleneck) - however, generation of a file means results can be loaded rather quickly
- npm run format - prettier js/*.js --single-quote --no-semi --print-width=120 --write
- giving cleaner builds for app - by retaining dev dependencies is separate folder
- graphPlugin -> PluginManager - navigateBack -> Navigation.back() - navigateForward -> Navigation.forward() - graphPlugin.navigateTo - clearNavigation -> State.clearNavigation() - plugin's zoom function should not call navigation - navigation calls navigate to which calls zoom - actions should trigger navigation call
- make pluginmanager more flexible
- also upgrade dependencies - d3 v3-v4 api migration - phonton npm package (fix #29) - bumped flamegraph version to retain values after zooming
- reenable scanning previews
- also fix up 3d transitions/animations - modularize more stuff (as plugins)
- eg. Navigation.updatePath -> State.navigateTo() - State.highlightPath() allows different components to react to highlights (mouseenter, mouseleave)
zz85
changed the title
Closed
- travis now does builds, packaging and release to github
- also make treemaps follow route conventions
- Add load last button - highlight path in listview - compress LASTLOAD_FILE - move data processing
- now synchronizes across the plugins - fix RAFTaskRunner so that it schedules tasks on next RAF, not immediately
- Internal app structure refactoring - Update libs - Electron 1.7.8 - D3 (see https://github.com/d3/d3/blob/master/CHANGES.md https://iros.github.io/d3-v4-whats-new/) - Refactor chart plugin routing - Flamegraphs - Shared colors for treemap views - List view of directory - Sort by size - Bump tag - Automatic builds release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List View
Flamecharts
Treeviews
