Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an option to store error responses in CLI #38

Closed
kmike opened this issue Nov 3, 2022 · 0 comments · Fixed by #47
Closed

Provide an option to store error responses in CLI #38

kmike opened this issue Nov 3, 2022 · 0 comments · Fixed by #47

Comments

@kmike
Copy link
Collaborator

kmike commented Nov 3, 2022

Sometimes it's nice to get both successful and error responses in the output.
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Sep 8, 2023
@adnan-awan
Provide an option to store error responses in CLI
11c5a95 
- Make initial change to write error response as well when --include-all-responses flag is passed.
- zytedata#38
@adnan-awan adnan-awan mentioned this issue Sep 8, 2023
Merged
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Dec 28, 2023
@adnan-awan
Perform the followings,
e6b6bd4 
- Improvement by PR suggestion
- Add tests for the current changes.
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 16, 2024
@adnan-awan
Perform the followings,
e164e77 
- Refactor the test using mocks
- Add dependency
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 17, 2024
@adnan-awan
Perform the followings,
d97e0b7 
- Remove RequestError import
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 21, 2024
@adnan-awan
Perform the followings,
9337e69 
- address the comments in PR
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 23, 2024
@adnan-awan
Perform the followings,
ca81a62 
- address the comments in PR
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 23, 2024
@adnan-awan
Perform the followings,
068a001 
- change the domain to forbidden.example
- zytedata#38
adnan-awan added a commit to adnan-awan/python-zyte-api that referenced this issue Jan 24, 2024
@adnan-awan
Perform the followings,
3362da0 
- change the domain to forbidden.example
- zytedata#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide an option to store error responses in CLI adnan-awan/python-zyte-api
1 participant
@kmike