Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to Angular 8. #214

Merged
merged 10 commits into from
Jul 17, 2019
Merged

Updated to Angular 8. #214

merged 10 commits into from
Jul 17, 2019

Conversation

N-Andronopoulos
Copy link
Contributor

Why:
Cause I need to upgrade my project from Angular 7 to 8.
It fails on ng upgrade.

Changes:
Includes automatic code migrations of Angular 8.
Added tslib to dev dependencies.
Updated zxing/library, codalyzer, tsickle, ng-packagr and typescript.
Housekeeping for error free linting.

@N-Andronopoulos
Updated to angular 8.
d77b7ae 
Added tslib to dev dependencies.
@odahcam
Copy link
Member

odahcam commented Jun 27, 2019

Sorry, I'm a bit confused here cause I'm currently using this lib in a Angular 8 app in production. 🤔

@N-Andronopoulos
Copy link
Contributor Author

N-Andronopoulos commented Jun 28, 2019 •
edited
Loading

The problem is that I want to upgrade a project of mine to Angular 8 (from 7) using ng update (angular cli). It fails because this library uses angular 7 and the dependency check fails.
Also why not, I think upgrading dependencies is a good thing in general.

@odahcam
Copy link
Member

odahcam commented Jun 29, 2019

As it will take a few days til the next release, a workaround for you would be uninstall it, upgrade your project and then install the lib again. It worked without problems for me.

odahcam
odahcam requested changes Jul 5, 2019
View reviewed changes
N-Andronopoulos
N-Andronopoulos commented Jul 7, 2019
View reviewed changes
Copy link
Contributor Author

@N-Andronopoulos N-Andronopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accepted your comments.
Also I adjusted typescript to "typescript": ">=3.4.0 <3.5.0" (took it from angularfire2).

odahcam
odahcam approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@odahcam odahcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for CI to finish.

@kristijanbambir
Copy link

If I'm not mistaken, this PR is missing peer dependencies update in projects/zxing-scanner/package.json as well.

@N-Andronopoulos
Updated dependencies on lib folder.
99022bc 
Minor code lint & JSDoc updates.
@odahcam
Copy link
Member

odahcam commented Jul 14, 2019

That dependencies were the most important, hehe. I'm curious about the CI, I think it's frozen.

@kristijanbambir
Copy link

Any chance this could be merged soon? 😃

odahcam
odahcam requested changes Jul 16, 2019
View reviewed changes
@odahcam odahcam changed the base branch from master to develop July 16, 2019 23:16
odahcam
odahcam reviewed Jul 17, 2019
View reviewed changes
Copy link
Member

@odahcam odahcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lez go.

@odahcam odahcam merged commit cd1e2b1 into zxing-js:develop Jul 17, 2019
@odahcam odahcam mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odahcam odahcam odahcam requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N-Andronopoulos @odahcam @kristijanbambir