feat: expose sdkVersion on the controller node too (#4388)

zwave-js · Mar 18, 2022 · 5052d7d · 5052d7d
1 parent 6e6b3f7
commit 5052d7d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/packages/zwave-js/src/lib/commandclass/VersionCC.ts b/packages/zwave-js/src/lib/commandclass/VersionCC.ts
@@ -55,6 +55,13 @@ export function getSDKVersionValueId(): ValueID {
 	};
 }
 
+export function getSDKVersionMetadata(): ValueMetadata {
+	return {
+		...ValueMetadata.ReadOnlyString,
+		label: "SDK version",
+	};
+}
+
 export enum VersionCommand {
 	Get = 0x11,
 	Report = 0x12,
@@ -636,10 +643,7 @@ export class VersionCCZWaveSoftwareReport extends VersionCC {
 
 	private _sdkVersion: string;
 	@ccValue({ minVersion: 3 })
-	@ccValueMetadata({
-		...ValueMetadata.ReadOnlyString,
-		label: "SDK version",
-	})
+	@ccValueMetadata(getSDKVersionMetadata())
 	public get sdkVersion(): string {
 		return this._sdkVersion;
 	}

diff --git a/packages/zwave-js/src/lib/controller/Controller.ts b/packages/zwave-js/src/lib/controller/Controller.ts
@@ -79,6 +79,8 @@ import {
 import {
 	getFirmwareVersionsMetadata,
 	getFirmwareVersionsValueId,
+	getSDKVersionMetadata,
+	getSDKVersionValueId,
 } from "../commandclass/VersionCC";
 import type { Driver, RequestHandler } from "../driver/Driver";
 import { cacheKeys, cacheKeyUtils } from "../driver/NetworkCache";
@@ -983,6 +985,11 @@ export class ZWaveController extends TypedEventEmitter<ControllerEventCallbacks>
 		controllerValueDB.setValue(getFirmwareVersionsValueId(), [
 			this._firmwareVersion,
 		]);
+		controllerValueDB.setMetadata(
+			getSDKVersionValueId(),
+			getSDKVersionMetadata(),
+		);
+		controllerValueDB.setValue(getSDKVersionValueId(), this._sdkVersion);
 
 		if (
 			this.type !== ZWaveLibraryTypes["Bridge Controller"] &&