Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive : Create a modal for add to zuri button #429

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

yemisi567
Copy link
Contributor

@yemisi567 yemisi567 commented Sep 4, 2021

Before submitting your PR for review

  • Run npm run eslint to find errors in code syntax/format
  • Run npm run eslint:fix to fix all auto-fixable errors in source code and auto-format with prettier
  • Ensure you fix any linting errors displayed after running any of the above commands
  • Ensure you fix all merge conflicts before sending PR

What does this PR do?
Adds a functionality for the add to zuri button on the google drive page

#429 (Google Drive : Create a modal for add to zuri button #429)

Summarise the main tasks handled in the pull request
Creating a Modal Component

Description of Task to be completed?
Add a Modal to the 'Add to Zuri Button'

Describe (in detail) what the task completed in the pull request does as per the relevant task
This task creates a functionality for the add to zuri button on the google drive page, onClick of the 'Add to Zuri button, a modal pops up asking users to enter a comment indicating why they want to add google drive to the zuri plugin tools

How should this be manually tested?
https://zurimodal.netlify.app/googledrive

Give bullet point instructions on how to setup the code and test it manually (Assume no prior experience on JS or code)
Step 1: yarn start
Step 2: From the homepage , I click on the google drive card
Step 3: Then Click on the 'Show download Page'
Step 4: Then click on the 'add to zuri' button before i could see the modal

Any background context you want to provide?

Any pertinent information that should be considered

What is the link to the issue on Github?

Issue #429

@oscar-ekeyekwu Please review
Questions:

If something is unclear or you want some questions to be addressed by your peers, mention them here

@hokagedemehin
Copy link
Contributor

Hi @yemisi567

The instructions you gave in the description is not clear on how to test your code,

These were the steps I had to take in order to see the issue you worked on

  • From the homepage, I click on the Google drive card

  • Then I clicked on the "show download Page"

  • Then I click on the "add to Zuri" button before I could see the modal

I believe that would have more straightforward, Asides from that the code has no merge conflicts

@yemisi567
Copy link
Contributor Author

Hi @yemisi567

The instructions you gave in the description is not clear on how to test your code,

These were the steps I had to take in order to see the issue you worked on

  • From the homepage, I click on the Google drive card
  • Then I clicked on the "show download Page"
  • Then I click on the "add to Zuri" button before I could see the modal

I believe that would have more straightforward, Asides from that the code has no merge conflicts

thanks..i have corrected it

@oscar-ekeyekwu oscar-ekeyekwu merged commit 9bed87a into zurichat:dev Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants