Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't immediately send & send multiple images. #5125

Closed
wants to merge 1 commit into from
Closed

Don't immediately send & send multiple images. #5125

wants to merge 1 commit into from

Conversation

AkashDhiman
Copy link
Member

TODO:

  • Choose better name for toAttachmentResponse method.
  • Break into multiple commits.
  • FileName isn't appropriate, react-native-image-picker modifies
    it. (it's along the line of rn_image_picker_lib_temp_*)

Fixes: #2366
Fixes: #4540

@AkashDhiman
image-picker [wip]: Don't immediately send & Send Multiple.
b9dbd9d 
TODO:

* Choose better name for `toAttachmentResponse` fn.
* Break into multiple commits.
* FileName isn't appropriate, `react-native-image-picker` modifies
  it. (it's along the line of `rn_image_picker_lib_temp_*`)
@AkashDhiman
Copy link
Member Author

AkashDhiman commented Nov 10, 2021 •
edited
Loading

An error without any side effect as far as i can tell right now happens whenever I attach any file (image or otherwise)

 ERROR  Unhandled Zulip API event
 ERROR      type: "attachment"
    op: "update",
    attachment: {...},
    upload_space_use: 23632026,
    id: 34

I wonder what's that about?

@chrisbobbe
Copy link
Contributor

An error without any side effect as far as i can tell right now happens whenever I attach any file (image or otherwise)

[…]

I wonder what's that about?

That looks like #4687.

@gnprice gnprice added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Dec 2, 2021
@chrisbobbe chrisbobbe mentioned this pull request Aug 23, 2022
Merged
@chrisbobbe
Copy link
Contributor

Closing as superseded by #5474 and #5638. Thanks for your work! 🙂

@chrisbobbe chrisbobbe closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't immediately send attachment on upload [Android] Multiple file selection when uploading pictures.
3 participants
@AkashDhiman @chrisbobbe @gnprice