Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios chinese input bug fix #3036

Closed
wants to merge 1 commit into from
Closed

Conversation

x007007007
Copy link

#3033 bug fix

@borisyankov
Copy link
Contributor

Thanks for working on this issue.
We have another possible solution for this problem (making the component uncontrolled), but I am not 100% certain that it is solving the issue you are having.

To make the commit easier to review, would you do the following three changes:

  • run yarn prettier on this commit so the formatting is consistent with our established code style. This will make the diff smaller (few lines have unnecessary spaces) and easier to read
  • make sure the tests pass (currently Flow is complaining about missing props)
  • Add few lines to the commit message explaining what the issue you encounter is, and why your changes fix it.

@x007007007
Copy link
Author

#2434 will fix this bug

@x007007007 x007007007 closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants