Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android build: Allow gradle to use more memory #1324

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Feb 4, 2025

Fixes #1330.

Recently, we have been running out of memory for the CI builds. It's likely that we were close to reaching the upperbound for some time, and some upstream change pushes us past that limit. Allocate more memory so that the CI can pass again.

CZO discussion:
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Execution.20failed.20for.20task.20'.3Aapp.3AcompileDebugKotlin'

@PIG208
Copy link
Member Author

PIG208 commented Feb 4, 2025

Looks like Xmx2048M is still not enough. Bumping it again.

@PIG208 PIG208 force-pushed the pr-build branch 2 times, most recently from 2fc3919 to 38c283b Compare February 4, 2025 22:59
@PIG208
Copy link
Member Author

PIG208 commented Feb 4, 2025

Xmx2560M doesn't work either. Bumping it to Xmx3072M.

@PIG208
Copy link
Member Author

PIG208 commented Feb 4, 2025

Will re-run this a few times to confirm that this succeeds continuously.

@PIG208
Copy link
Member Author

PIG208 commented Feb 5, 2025

This has been passing consistently. Still not too sure about the cause though. I suspect that flutter/flutter#162675 could be relevant.

@PIG208
Copy link
Member Author

PIG208 commented Feb 5, 2025

While the investigation to identify the cause is pending, let's merge this workaround first to fix the CI.

@PIG208 PIG208 requested a review from gnprice February 5, 2025 18:11
@gnprice gnprice added the integration review Added by maintainers when PR may be ready for integration label Feb 5, 2025
@gnprice
Copy link
Member

gnprice commented Feb 5, 2025

Thanks for doing these experiments!

The commit message no longer seems accurate for what we know now:

Recently, we have been running out of memory for the CI builds. It's
likely that we were close to reaching the upperbound for some time, and
some upstream change pushes us past that limit. Allocate more memory so

Given that it was such a steep change in the memory use, there's no longer any reason to think that we were near the old upper bound.

I'll fix that, and also add some text as to why we're increasing the limit by so much, and also turn the chat link into a permalink:

Since Monday, CI builds have been running out of memory,
presumably due to some upstream change.  Allocate more memory
so that the CI can pass again.

The limit was 1.5 GiB, but now even 2.5 GiB doesn't seem to be
enough.  So increase it to 3 GiB.

CZO discussion:
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Execution.20failed.20for.20task.20'.3Aapp.3AcompileDebugKotlin'/near/2076887

then merge.

Fixes zulip#1330.

Since Monday, CI builds have been running out of memory,
presumably due to some upstream change.  Allocate more memory
so that the CI can pass again.

The limit was 1.5 GiB, but now even 2.5 GiB doesn't seem to be
enough.  So increase it to 3 GiB.

CZO discussion:
  https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Execution.20failed.20for.20task.20'.3Aapp.3AcompileDebugKotlin'/near/2076887

Signed-off-by: Zixuan James Li <[email protected]>
@gnprice gnprice merged commit ca26330 into zulip:main Feb 5, 2025
@gnprice
Copy link
Member

gnprice commented Feb 5, 2025

Done. Also filed #1330 for the issue this fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing in Android build as out of memory
2 participants