Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card due date #5

Closed
zsh-eng opened this issue Apr 12, 2024 · 0 comments · Fixed by #16
Closed

Fix card due date #5

zsh-eng opened this issue Apr 12, 2024 · 0 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@zsh-eng
Copy link
Owner

zsh-eng commented Apr 12, 2024

Currently, we update the due date of the card locally by changing the .due field on the Card.

This is the wrong way of updating cards as it means other details, such as stability, State, etc. are not being updated.
Instead, we should abstract out the functionality of updating the card using the ts-fsrs library and reuse these functions on both the frontend and the backend to ensure that updates are in sync.

@zsh-eng zsh-eng converted this from a draft issue Apr 12, 2024
@zsh-eng zsh-eng added the bug Something isn't working label Apr 12, 2024
@github-project-automation github-project-automation bot moved this from Refactor / Debug to Done in spaced-project Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant