More CLI Improvements #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
cli/docter_checks
branch
from
77607df to
594405c
Compare
If an undefined attribute of a submodule is accessed, fall back to same attribute of the submodule's parent.
Commandline args should be merged with the submodule's config. Compare config values to None instead of False, so empty lines and False can be used as values.
This is needed for inheritance to work with commands that have dashes in their names.
* Align cformat rules with current CI implementation * Optimise file walking
* Beef up how `qmk doctor` works. * improve the `git submodule status` parsing. h/t @Erovia * Fix whitespace and imports * yapf * Add documentation for the new doctor functionality * Replace type_unchanged() with str() * remove unused modules * Update lib/python/qmk/cli/doctor.py Co-Authored-By: Erovia <[email protected]> Co-authored-by: Erovia <[email protected]>
* Fixed OS detection on newer MSYS installations * made OS sting lower case
drashna
changed the title
* wip * tested and working * remove unused import * Update lib/python/qmk/questions.py Co-Authored-By: Erovia <[email protected]> * fix flake8 errors Co-authored-by: Erovia <[email protected]>
* Add context sensitive compile, without config check * Initial full working state. Plan to refactor * Refactor loop for simplicity, add comments * Update docs/cli.md with qmk compile examples * Simplify path for keyboard derivation * Update path to use path.join instead of concat * Refactor keyboard path, the skully way * Add in keymap folder support * Add /layouts compile support * Update docs/cli.md with empty compile in layouts * Add comments to compile.py * Update docs for clarity, and fix compile error typo * Fix config option compile * Fix layout compile and failure mode * Add rules.mk check * Fix variable names for global config * Add in_layout priority * Remove default fallback in favor of throw, update docs * Add keymap folder context * Fix formatting * Add os import * Convert to create_make_command * Fix Travis lint errors * Remove blank line with whitespace * Add blank lines for readability * Remove unnecessary config logic * Update Docs to add flash Co-Authored-By: skullydazed <[email protected]> * Shift config precedence to MILC Co-authored-by: skullydazed <[email protected]>
Create GitHub Actions cli test workflow and remove travis runs of 'qmk pytest'
fdidron
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to keep feature parity with the qmk cli (
bin/qmk).Align cformat rules with current CI implementation (qmk#7936)
Beef up how
qmk doctorworks. (qmk#7375)Qmk doctor os check to support newer msys2/w10 installations (qmk#8031)
Improve the functionality of qmk.questions (qmk#8020)
Add QMK Compile Context Sensitivity (qmk#6884)
CI: Add workflow for CLI testing (qmk#7357)