Fix a clang optimization causing incorrect results for ST::string::fr…

…om_int in Release builds
zrax · Mar 15, 2023 · 7afa0a0 · 7afa0a0
1 parent 565656e
commit 7afa0a0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/include/st_string_priv.h b/include/st_string_priv.h
@@ -154,7 +154,9 @@ namespace _ST_PRIVATE
     {
         typedef typename std::make_unsigned<int_T>::type uint_T;
         ST::uint_formatter<uint_T> formatter;
-        formatter.format(std::abs(value), radix, upper_case);
+        uint_T abs_value = value < 0 ? -static_cast<uint_T>(value)
+                                     :  static_cast<uint_T>(value);
+        formatter.format(abs_value, radix, upper_case);
 
         ST::char_buffer result;
         if (value < 0) {