Several German television and shopping providers were added. Language support was added to the Wikipedia and the google provider. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoro
changed the title
zquestz
reviewed
Dec 1, 2021
|
PR looks good but a few nits:
Thanks for the contribution! |
zquestz
reviewed
Dec 1, 2021
zquestz
reviewed
Dec 1, 2021
zquestz
reviewed
Dec 1, 2021
|
|
||
| // Tags returns the tags relevant to this provider. | ||
| func (p *Provider) Tags() []string { | ||
| return []string{"search"} |
There was a problem hiding this comment.
I think this should be left blank, search really indicates a more general purpose search like google/duckduckgo/etc. Most users won't want to search maps as well.
There was a problem hiding this comment.
Reminder, we should remove this tag. =)
zquestz
reviewed
Dec 1, 2021
zquestz
reviewed
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the second german television station (ZDF) to the available providers.