Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank data set template #973

Merged
merged 15 commits into from
Mar 22, 2021
Merged

Blank data set template #973

merged 15 commits into from
Mar 22, 2021

Conversation

katelynienaber
Copy link
Contributor

Adding a standard DS template which contains no parameters. For use with DS templates in Zowe Explorer.

Linked CLI issue (can be closed when this is merged): #947

@katelynienaber katelynienaber added the enhancement New feature or request label Mar 8, 2021
@katelynienaber katelynienaber self-assigned this Mar 8, 2021
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template addition looks OK to me.
Left a few comments 😋

…idn't touch that command) and duplicate identifier

Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #973 (2daa6bb) into master (3b6d749) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   90.60%   90.61%   +0.01%     
==========================================
  Files         349      349              
  Lines        5067     5074       +7     
  Branches      688      686       -2     
==========================================
+ Hits         4591     4598       +7     
  Misses        471      471              
  Partials        5        5              
Impacted Files Coverage Δ
packages/zosfiles/src/methods/copy/Copy.ts 100.00% <ø> (ø)
...ges/zosfiles/src/methods/create/Create.defaults.ts 100.00% <ø> (ø)
packages/zosfiles/src/methods/invoke/Invoke.ts 100.00% <ø> (ø)
packages/zosfiles/src/methods/rename/Rename.ts 100.00% <ø> (ø)
packages/core/src/rest/ZosmfHeaders.ts 100.00% <100.00%> (ø)
packages/core/src/rest/ZosmfRestClient.ts 90.62% <100.00%> (+0.96%) ⬆️
packages/zosfiles/src/methods/create/Create.ts 92.05% <100.00%> (+0.16%) ⬆️
...files/src/methods/create/CreateDataSetType.enum.ts 100.00% <100.00%> (ø)
packages/zosfiles/src/methods/delete/Delete.ts 94.02% <100.00%> (ø)
packages/zosfiles/src/methods/get/Get.ts 96.55% <100.00%> (-0.12%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c95d0c...2daa6bb. Read the comment docs.

@katelynienaber katelynienaber marked this pull request as ready for review March 12, 2021 12:56
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @katelynienaber,
Is this change expected to be consumed by the Zowe Explorer this PI?

Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katelynienaber
Copy link
Contributor Author

katelynienaber commented Mar 15, 2021

Hey @katelynienaber,
Is this change expected to be consumed by the Zowe Explorer this PI?

@zFernand0 Imho this won't be consumed until next PI. But if we get lucky and things go fast, maybe it would P:

To implement templates I need to use the API for next. Because I just want to build the templates system once, and have the templates stored in the config file. I would wait until the basic framework for consuming the API is built up in ZE before complicating things with templates...so...

Template prerequisites:

  • The CLI API needs to be working
  • We need to consume the API in Zowe Explorer

Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@katelynienaber katelynienaber requested a review from t1m0thyj March 19, 2021 14:05
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@zFernand0 zFernand0 merged commit a476285 into master Mar 22, 2021
@zFernand0 zFernand0 deleted the add-blank-ds-type branch March 22, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants