-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank data set template #973
Conversation
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template addition looks OK to me.
Left a few comments 😋
packages/cli/src/zosfiles/create/blankPds/BlankPDS.definition.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/zosfiles/create/blankPds/BlankPDS.definition.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: katelynienaber <[email protected]>
…idn't touch that command) and duplicate identifier Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 90.60% 90.61% +0.01%
==========================================
Files 349 349
Lines 5067 5074 +7
Branches 688 686 -2
==========================================
+ Hits 4591 4598 +7
Misses 471 471
Partials 5 5
Continue to review full report at Codecov.
|
Signed-off-by: katelynienaber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @katelynienaber,
Is this change expected to be consumed by the Zowe Explorer this PI?
packages/cli/__tests__/zosfiles/__integration__/create/ds/__scripts__/create_ds_help.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zFernand0 Imho this won't be consumed until next PI. But if we get lucky and things go fast, maybe it would P: To implement templates I need to use the API for Template prerequisites:
|
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Signed-off-by: katelynienaber <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Adding a standard DS template which contains no parameters. For use with DS templates in Zowe Explorer.
Linked CLI issue (can be closed when this is merged): #947