-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #2259 and flagged code smells #2440
Conversation
Signed-off-by: Andrew W. Harn <[email protected]>
📅 Suggested merge-by date: 3/5/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and changes LGTM, thanks for the enhancement Andrew!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2440 +/- ##
========================================
Coverage 91.49% 91.49%
========================================
Files 641 641
Lines 18358 18360 +2
Branches 3978 3869 -109
========================================
+ Hits 16796 16799 +3
+ Misses 1560 1559 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew W. Harn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @awharn!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Resolves #2259
How to Test
Run
ZOWE_SHOW_SECURE_ARGS=true; zowe config list
and observe the secure values being shown.Review Checklist
I certify that I have:
Additional Comments