Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #2259 and flagged code smells #2440

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Resolve #2259 and flagged code smells #2440

merged 2 commits into from
Feb 19, 2025

Conversation

awharn
Copy link
Member

@awharn awharn commented Feb 19, 2025

What It Does
Resolves #2259

How to Test

Run ZOWE_SHOW_SECURE_ARGS=true; zowe config list and observe the secure values being shown.

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link

📅 Suggested merge-by date: 3/5/2025

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and changes LGTM, thanks for the enhancement Andrew!

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (e80dcd2) to head (b62bb71).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2440    +/-   ##
========================================
  Coverage   91.49%   91.49%            
========================================
  Files         641      641            
  Lines       18358    18360     +2     
  Branches     3978     3869   -109     
========================================
+ Hits        16796    16799     +3     
+ Misses       1560     1559     -1     
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn!

@awharn awharn requested a review from anaxceron February 19, 2025 18:52
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit eb5696b into master Feb 19, 2025
25 of 26 checks passed
@zFernand0 zFernand0 deleted the update-config-list branch February 19, 2025 22:02
@zFernand0 zFernand0 added the release-minor Indicates a minor feature has been added label Feb 19, 2025
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-minor Indicates a minor feature has been added released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Display secure values in zowe config list when the property ZOWE_SHOW_SECURE_ARGS is set
5 participants