Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed alias for copy command definition #2423

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fixed alias for copy command definition #2423

merged 4 commits into from
Jan 31, 2025

Conversation

pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Jan 30, 2025

What It Does

Removed -- from safe-replace alias sr.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Pujal <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for the quick response to:

@zFernand0 zFernand0 requested a review from awharn January 30, 2025 15:30
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (591ebd5) to head (0df4dcc).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2423    +/-   ##
========================================
  Coverage   91.36%   91.36%            
========================================
  Files         639      639            
  Lines       18283    18283            
  Branches     3960     3850   -110     
========================================
  Hits        16704    16704            
  Misses       1577     1577            
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0
Copy link
Member

Given that the ----sr alias was not published, there is no need for a changelog entry.
That said, no need to worry about the Changelog check 🙏
https://github.com/zowe/zowe-cli/actions/runs/13055703586/job/36426127073?pr=2423

@pujal0909 pujal0909 marked this pull request as ready for review January 31, 2025 14:30
Copy link

📅 Suggested merge-by date: 2/14/2025

@zFernand0 zFernand0 merged commit 9340db9 into master Jan 31, 2025
28 checks passed
@zFernand0 zFernand0 deleted the fix-alias branch January 31, 2025 14:34
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants