Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary space being set on blank dataset type #1723

Merged
merged 1 commit into from
May 26, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented May 25, 2023

What It Does
Resolves #1595 by removing validation that sets secondary extents to 1 for BLANK type dataset templates.

How to Test
Attempt to allocate a dataset using zowe files create ds <DSN> --dst BASIC and view the dataset properties via ISPF. Secondary extents will be 0. Or you'll get a dynamic allocation error from z/OSMF because you didn't set the primary extents.

Review Checklist
I certify that I have:

Additional Comments

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e8a7f9d) 92.76% compared to head (096c049) 92.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files         416      416           
  Lines        6908     6909    +1     
  Branches     1219     1220    +1     
=======================================
+ Hits         6408     6409    +1     
  Misses        499      499           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zosfiles/src/methods/create/Create.ts 92.78% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@KevinLoesch1 KevinLoesch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@awharn awharn added the release-patch Indicates a patch to existing code has been applied label May 26, 2023
@awharn awharn merged commit ef1d26a into master May 26, 2023
@awharn awharn deleted the fix-secondary-space branch May 26, 2023 17:20
@awharn awharn restored the fix-secondary-space branch May 26, 2023 17:20
@awharn awharn deleted the fix-secondary-space branch May 26, 2023 17:21
@github-actions github-actions bot removed the release-patch Indicates a patch to existing code has been applied label May 26, 2023
@t1m0thyj t1m0thyj added the release-patch Indicates a patch to existing code has been applied label May 26, 2023
@github-actions
Copy link

Release succeeded for the master branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zowe files create ds always assume secondary space of 1
3 participants