Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate CICSplexes so they don't appear in the tree #228

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

enamkhan
Copy link
Contributor

@enamkhan enamkhan commented Feb 7, 2025

Filter duplicate cicsplexes so that these do not appear in the tree.

How to Test
Have added unit tests for the compare function,

Review Checklist
I certify that I have:

Additional Comments
This is for defect #227.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.12%. Comparing base (d1fcf79) to head (f0ab9cd).

Files with missing lines Patch % Lines
packages/vsce/src/utils/profileManagement.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   40.04%   40.12%   +0.07%     
==========================================
  Files         148      149       +1     
  Lines        5072     5082      +10     
  Branches      847      848       +1     
==========================================
+ Hits         2031     2039       +8     
- Misses       3041     3043       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enamkhan enamkhan force-pushed the khane-filter-cicsplexes-for-duplicates branch from e3af841 to 8b99472 Compare February 12, 2025 11:24
Signed-off-by: enam-khan <[email protected]>
Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!! Very much appreciated.

Couple comments, mainly around typing, then we're good to go!

Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Enam.

This has been tested against real systems facing this issue to see it in action.

*
*/

export interface ICicsPlexInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for future reference, this is temporary and will be replaced by an SDK interface.

Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
@enamkhan enamkhan changed the title Removed duplicate cicsplexes so they don't appear in the tree Removed duplicate CICSplexes so they don't appear in the tree Feb 12, 2025
Signed-off-by: enam-khan <[email protected]>
@AndrewTwydell AndrewTwydell merged commit f4cb407 into main Feb 12, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the khane-filter-cicsplexes-for-duplicates branch February 12, 2025 16:51
@AndrewTwydell AndrewTwydell added the release-patch Indicates a patch to existing code has been applied label Feb 12, 2025
Copy link

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants