-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicate CICSplexes so they don't appear in the tree #228
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 40.04% 40.12% +0.07%
==========================================
Files 148 149 +1
Lines 5072 5082 +10
Branches 847 848 +1
==========================================
+ Hits 2031 2039 +8
- Misses 3041 3043 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: enam-khan <[email protected]>
e3af841
to
8b99472
Compare
Signed-off-by: enam-khan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!! Very much appreciated.
Couple comments, mainly around typing, then we're good to go!
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks Enam.
This has been tested against real systems facing this issue to see it in action.
* | ||
*/ | ||
|
||
export interface ICicsPlexInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for future reference, this is temporary and will be replaced by an SDK interface.
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Signed-off-by: enam-khan <[email protected]>
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Filter duplicate cicsplexes so that these do not appear in the tree.
How to Test
Have added unit tests for the compare function,
Review Checklist
I certify that I have:
Additional Comments
This is for defect #227.