Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier formatting #215

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Prettier formatting #215

merged 5 commits into from
Feb 27, 2025

Conversation

AndrewTwydell
Copy link
Contributor

@AndrewTwydell AndrewTwydell commented Jan 24, 2025

What It Does
Adds consistent formatting of files using Prettier. Lots of files changed but nothing functional, all cosmetic

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 67.90541% with 95 lines in your changes missing coverage. Please review.

Project coverage is 40.78%. Comparing base (44d8f8b) to head (f68fd66).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/vsce/src/commands/filterResourceCommands.ts 0.00% 11 Missing ⚠️
packages/sdk/src/rest/CicsCmciRestClient.ts 25.00% 9 Missing ⚠️
packages/vsce/src/commands/purgeTaskCommand.ts 0.00% 7 Missing ⚠️
...ackages/vsce/src/commands/closeLocalFileCommand.ts 0.00% 6 Missing ⚠️
...ommands/disableCommands/disableLocalFileCommand.ts 0.00% 6 Missing ⚠️
...mands/disableCommands/disableTransactionCommand.ts 0.00% 6 Missing ⚠️
...ommands/enableCommands/enableTransactionCommand.ts 0.00% 6 Missing ⚠️
.../vsce/src/trees/treeItems/CICSLocalFileTreeItem.ts 14.28% 6 Missing ⚠️
.../commands/disableCommands/disableProgramCommand.ts 0.00% 5 Missing ⚠️
.../commands/enableCommands/enableLocalFileCommand.ts 0.00% 5 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   40.69%   40.78%   +0.08%     
==========================================
  Files         151      151              
  Lines        5072     5056      -16     
  Branches      875      817      -58     
==========================================
- Hits         2064     2062       -2     
+ Misses       3008     2994      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JTonda JTonda requested a review from zFernand0 January 28, 2025 16:07
@JTonda JTonda marked this pull request as draft January 28, 2025 16:08
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it's worth trying to revive this PR or just opening a new one 😋
as a general comment, I agree with the changes/rules in this PR 🙏

Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
@AndrewTwydell AndrewTwydell marked this pull request as ready for review February 27, 2025 11:46
Signed-off-by: Andrew Twydell <[email protected]>
@AndrewTwydell AndrewTwydell added the release-current Indicates that there is no new functionality being delivered label Feb 27, 2025
Copy link
Contributor

@enamkhan enamkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for keeping the rules simple. 🏃💨
Also, thanks for allowing me the change to review it 🙏
Feel free to merge whenever you see fit! 🥳

@AndrewTwydell AndrewTwydell merged commit 2d13589 into main Feb 27, 2025
19 checks passed
@AndrewTwydell AndrewTwydell deleted the prettier-formatting branch February 27, 2025 20:42
@github-actions github-actions bot removed the release-current Indicates that there is no new functionality being delivered label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

5 participants