-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme and fix lint issues #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #109 +/- ##
==========================================
- Coverage 93.53% 93.17% -0.37%
==========================================
Files 73 73
Lines 758 718 -40
Branches 94 54 -40
==========================================
- Hits 709 669 -40
Misses 49 49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic!
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
c1eb587
to
10ec4a8
Compare
Windows builds fail due to a quoting problem in the "Update Dependencies" script
Update Thanks @t1m0thyj for the quick fix |
@anaxceron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one comment, otherwise, lookin' great!
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0! 😁
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
parms.arguments
How to Test
Review Checklist
I certify that I have:
Additional Comments
This should take care of the remaining V3 conformance work