CSL-JSON hardening #109
Merged
CSL-JSON hardening #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technically `literal` and `year` keys are in CSL-JSON or at least they are now
- updated serde because I thought it would fix an issue, may as well keep it
all this was done through the new crates/io/tests/json test suite. test: - parses the JSON schema to auto-generate test cases - tests for unknown variables - tests all classes of variable are parsed as the correct AnyVariable variant - tests that these tests are exhaustive test-suite: - adds date_IsUncertainDate as a pure boolean test dates: - also fixes <if is-uncertain-date="issued"> not being implemented (it passed date_Uncertain spuriously, because it rendered circa term anyway) - ignores unrecognised fields in dates - ignores additional entries in date-parts arrays - ignores more invalid values - accepts bool for circa - stores circa on literal as well - log warnings for many cases variables: - adds _everything_ from the latest CSL-JSON schema
cormacrelf
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92, fixes #99
Basically adds a big test suite for the JSON input, some of which is generated from the schema itself, and hammers the Deserialize impl with inputs. The guiding principle is that anything within the schema should not fail to parse with an Error, and many more things should be silently ignored. I think the one thing left is that the schema says "number" everywhere but should probably say "integer" instead, so I don't know what happens with floating point inputs.
Last commit fixes the most things.
"issued": {"year": 1995}test-suite runshortTitle, expectedany CSL variable#92