Support Python 3.13

[icemac]

Dependencies:

• Release of zope.interface to be able to run on Python 3.13b1
• Fix the problem reported in Test failure in test_filehandler_reopen_thread_safety on Python 3.13 #96

Fixes #96

[dataflake]

zope.interface release 6.4 is now published.

[icemac]

I do not plan to work on fixing this issue, as I have no clue what is going wrong here.

[d-maurer]

Michael Howitz wrote at 2024-5-16 00:07 -0700:

I do not plan to work on fixing this issue, as I have no clue what is going wrong here.

The test `ZConfig.components.logger.tests.test_logger.TestReopeningLogfiles.test_filehandler_reopen_thread_safety`) tries to check (among others) that the `close` operation of `ZConfig.components.logger.loghandler.FileHandler` (derived from `logging.FileHandler`) uses a lock (to obtain thread safety). For this, it overrides the `acquire` and `release` methods of its handler instance. But, with Python 3.13, the inherited `close` no longer uses its `acquire/release` methods internally; instead it uses `with self.lock`. Correspondingly, the test's overrides are ineffective and the test fails (to recognize that thread safety is still guaranteed). Likely fix: do not override `acquire/release` but the `lock` attribute with a lock mockup recording acquire/release independently of whether the operations are called under their name or under `__enter__, __exit__`.

[tseaver]

The fix LGTM.

@d-maurer, I noticed that you removed a changelog entry. Shouldn't we have an entry , - Added support for Python 3.13, as well as adding the corresponding Trove classifier to setup.py?

[musicinmybrain]

Thanks! This fix works for me.

[d-maurer]

Tres Seaver wrote at 2024-5-18 06:36 -0700:

@tseaver requested changes on this pull request. ... @d-maurer, I noticed that you removed a changelog entry.

I removed a changelog entry which came from my previous work from PR #98 -- and has been inappropriate here.

Shouldn't we have an entry , `- Added support for Python 3.13`

We should! The current PR is still a draft and some fine points are still missing (changelog entry, trove classifiers, ...). Let's wait until @icemac declares the PR ready for review.

[tseaver]

@d-maurer Oops, I saw that we had finished all the issues @icemac noted, and went ahead and added them before merging. Sorry for being too quick on the trigger.

[icemac]

Thank you for the work to fix this PR.